Convert CN1Bluetooth to Maven and add CI #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted the legacy Ant project to a Maven multi-module structure. - Created `common`, `android`, `ios`, `javase`, `javascript`, `win`, and `lib` modules. - Migrated Java source code and native implementations to their respective modules. - Added a local Maven repository (`repo/`) to vendor `ca.weblite:codename1-json:1.0`. - Configured `pom.xml` files for Codename One build process. - Added GitHub Actions workflow (`.github/workflows/maven.yml`) to build with JDK 11. - Removed legacy Ant build artifacts and configuration files. - Configured ProGuard to suppress warnings for `ca.weblite.codename1.json` and internal packages during compliance checks.
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
- Converted the legacy Ant project to a Maven multi-module structure. - Created `common`, `android`, `ios`, `javase`, `javascript`, `win`, and `lib` modules. - Migrated Java source code and native implementations to their respective modules. - Added a local Maven repository (`repo/`) to vendor `ca.weblite:codename1-json:1.0` and resolved dependency issues. - Configured `pom.xml` files for Codename One build process targeting Java 8. - Added GitHub Actions workflow (`.github/workflows/maven.yml`) to build with JDK 11. - Removed legacy Ant build artifacts and configuration files. - Configured ProGuard to suppress warnings for `ca.weblite.codename1.json` and internal packages during compliance checks. - Fixed `lib/pom.xml` to remove dependency on non-existent css artifact.
- Converted the legacy Ant project to a Maven multi-module structure. - Created `common`, `android`, `ios`, `javase`, `javascript`, `win`, and `lib` modules. - Migrated Java source code and native implementations to their respective modules. - Added a local Maven repository (`repo/`) to vendor `ca.weblite:codename1-json:1.0` and resolved dependency issues. - Configured `pom.xml` files for Codename One build process targeting Java 8. - Added GitHub Actions workflow (`.github/workflows/maven.yml`) to build with JDK 11. - Removed legacy Ant build artifacts and configuration files. - Configured ProGuard to suppress warnings for `ca.weblite.codename1.json` and internal packages during compliance checks. - Fixed `lib/pom.xml` to remove dependency on non-existent css artifact.
- Converted the legacy Ant project to a Maven multi-module structure. - Created `common`, `android`, `ios`, `javase`, `javascript`, `win`, and `lib` modules. - Migrated Java source code and native implementations to their respective modules. - Removed dependency on `ca.weblite:codename1-json` by implementing lightweight JSON generation (`JSONUtils`) and parsing (`JSONParserUtils`) using Codename One built-ins. - Refactored `Bluetooth`, `Cordova`, and `CordovaCallback` to use `java.util.Map` instead of `JSONObject`. - Configured `pom.xml` files for Codename One build process targeting Java 8. - Added GitHub Actions workflow (`.github/workflows/maven.yml`) to build with JDK 11. - Restored `CordovaCallbackManager` methods required by native implementations and ensured callbacks run on EDT. - Removed legacy Ant build artifacts and configuration files. - Configured ProGuard to suppress warnings for internal packages.
- Converted the legacy Ant project to a Maven multi-module structure. - Created `common`, `android`, `ios`, `javase`, `javascript`, `win`, and `lib` modules. - Migrated Java source code and native implementations to their respective modules. - Removed dependency on `ca.weblite:codename1-json` by implementing lightweight JSON generation (`JSONUtils`) and parsing (`JSONParserUtils`) using Codename One built-ins. - Refactored `Bluetooth`, `Cordova`, and `CordovaCallback` to use `java.util.Map` instead of `JSONObject`. - Configured `pom.xml` files for Codename One build process targeting Java 8. - Added GitHub Actions workflow (`.github/workflows/maven.yml`) to build with JDK 11 and install `CodeNameOneBuildClient.jar`. - Restored `CordovaCallbackManager` methods required by native implementations and ensured callbacks run on EDT. - Removed legacy Ant build artifacts and configuration files. - Configured ProGuard to suppress warnings for internal packages.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts the
CN1Bluetoothproject from a legacy Codename One Ant structure to the modern Maven format. It restructures the project into multiple modules (common, android, ios, javase, etc.), migrates the source code and native implementations, and sets up a local repository for dependencies. A CI workflow using GitHub Actions is also added to verify the build using JDK 11.PR created automatically by Jules for task 16220451789768026049 started by @shai-almog