Fix Issue #2 - [BUG] Sidebar header text unreadable with certain theme lightness settings #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dynamic sidebar text color calculation based on background lightness - Implement `calculateSidebarTextColor` method in ThemeService - Update CSS to use CSS custom properties for sidebar text color - Add comprehensive unit tests for text color contrast calculation - Enhance theme adaptability by dynamically adjusting text color - Provide fallback color values for consistent readability
chandanshyam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(theme): Improve sidebar text color contrast with dynamic calculation
calculateSidebarTextColormethod in ThemeServiceChanges made to:
src/gui/src/css/style.css
src/gui/src/services/ThemeService.js
Added a Function CalculateSidebarColor Function to determine Sidebar text Color Based on background lightness
adjust the sidebar color based on lightness and contrast threshold dynamically
Added a new TestFile
Steps to Test
run command(In terminal)/ run this test:
npx mocha src/gui/test/theme_service.test.js --reporter speccheck if all 9 testCases Pass