Skip to content

fix: prevent TypeError when validating invalid social media image URLs #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrayagCodes wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: prevent TypeError when validating invalid social media image URLs #60

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a2da4b
fix: prevent TypeError when validating invalid social media image URLs
PrayagCodes Nov 25, 2025
cc71d49
update
PrayagCodes Nov 25, 2025
8199570
update
PrayagCodes Nov 25, 2025
8bb16f6
update
PrayagCodes Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/backend/src/services/PuterHomepageService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,18 +192,20 @@ class PuterHomepageService extends BaseService {

const bundled = env != 'dev' || use_bundled_gui;

let validated_social_media_image = social_media_image;

// if social media image is not a valid absolute URL, set it to null
if (social_media_image && !is_valid_url(social_media_image)) {
social_media_image = null;
if (validated_social_media_image && !is_valid_url(validated_social_media_image)) {
validated_social_media_image = null;
}

// social media image must end with a valid image extension
if (social_media_image && !/\.(png|jpg|jpeg|gif|webp)$/.test(social_media_image.toLowerCase())) {
social_media_image = null;
if (validated_social_media_image && !/\.(png|jpg|jpeg|gif|webp)$/.test(validated_social_media_image.toLowerCase())) {
validated_social_media_image = null;
}

// set social media image to default if it is not valid
const social_media_image_url = social_media_image || `${asset_dir}/images/screenshot.png`;
const social_media_image_url = validated_social_media_image || `${asset_dir}/images/screenshot.png`;

// Custom script tags to be added to the homepage by extensions
// an event is emitted to allow extensions to add their own script tags
Expand Down