Skip to content

Fix: Prevent background apps from stealing keyboard focus #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PrayagCodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent background apps from stealing keyboard focus #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/gui/src/UI/UIWindow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ async function UIWindow(options) {
options.window_class = (options.window_class !== undefined ? ' ' + options.window_class : '');

options.is_visible = options.is_visible ?? true;
options.background = options.background ?? false;

// if only one instance is allowed, bring focus to the window that is already open
if(options.single_instance && options.app !== ''){
Expand Down Expand Up @@ -579,7 +580,8 @@ async function UIWindow(options) {
$(el_window_head_icon).attr('src', window.icons['shared.svg']);
}
// focus on this window and deactivate other windows
if ( options.is_visible ) {
// BUT: Don't focus if this is a background app - background apps should not steal focus
if ( options.is_visible && !options.background ) {
$(el_window).focusWindow();
}

Expand Down Expand Up @@ -1410,7 +1412,10 @@ async function UIWindow(options) {
el_window_app_iframe.contentWindow.postMessage({msg: "drop", x: (window.mouseX - rect.left), y: (window.mouseY - rect.top), items: items}, '*');

// bring focus to this window
// BUT: Don't focus if this is a background app - background apps should not steal focus
if ( !options.background ) {
$(el_window).focusWindow();
}
}

// if this window is not a directory, cancel drop.
Expand Down Expand Up @@ -1552,10 +1557,13 @@ async function UIWindow(options) {
// make sure to cancel any previous timeouts otherwise the window will be brought to front multiple times
clearTimeout(drag_enter_timeout);
// If items are dragged over this window long enough, bring it to front
// BUT: Don't focus if this is a background app - background apps should not steal focus
if ( !options.background ) {
drag_enter_timeout = setTimeout(function(){
// focus window
$(el_window).focusWindow();
}, 1400);
}
},
leave: function (dragsterEvent, event) {
// cancel the timeout for 'bringing window to front'
Expand Down
1 change: 1 addition & 0 deletions src/gui/src/helpers/launch_app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,7 @@ const launch_app = async (options)=>{
is_resizable: window_resizable,
has_head: ! hide_titlebar,
show_in_taskbar: app_info.background ? false : window_options?.show_in_taskbar,
background: app_info.background,
});

// If the app is not in the background, show the window
Expand Down