Skip to content

Conversation

@JuliettaRozin
Copy link

SUMMARY

Issue stated that the search input in the "Change Visualization Type" (or View All Charts) modal must be manually clicked before the user types, adding unnecessary steps.
This solution works with the VizTypeGallery modal and automatically focuses the search input when the modal opens to be able to type immediately, using a useEffect that determines when the modal is opened.

CODE REVIEW & BEFORE/AFTER DEMO

Before/After Demo & Code Review

TESTING

The following manual tests were performed:

  • A chart is selected in Explore view and the "View All Charts" button is clicked
  • When the modal opens:
    • Cursor is automatically in the search input
    • You can type immediately without needing to click into the search input
  • The modal is closed and reopened: provides same performance as before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
  • Fixes Feature/fix auto focus text input #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant