FEAT (Chart): Auto focuses visual selection search input #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Issue stated that the search input in the "Change Visualization Type" (or View All Charts) modal must be manually clicked before the user types, adding unnecessary steps.
This solution works with the VizTypeGallery modal and automatically focuses the search input when the modal opens to be able to type immediately, using a useEffect that determines when the modal is opened.
CODE REVIEW & BEFORE/AFTER DEMO
Before/After Demo & Code Review
TESTING
The following manual tests were performed:
ADDITIONAL INFORMATION