Fix out-of-order notification processing#18
Closed
agentcooper wants to merge 2 commits intocoder:mainfrom
Closed
Conversation
agentcooper
added a commit
to agentcooper/acp-go-sdk
that referenced
this pull request
Feb 5, 2026
|
I'm also seeing this problem. |
Member
|
Thanks for working on this and for adding the integration coverage around ordering. I think this is effectively a duplicate of #8, and it also reintroduces the same class of queue-handling issues we discussed in the earlier iterations there:
Given that #8 already has the full history, discussion, and related fixes, I’d prefer that we consolidate there and close this as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the ACP client sometimes receives text chunk updates in the incorrect order.
I've added a failing integration test where the client connects to the server that sends numbers from 1 to 100 and the client verifies the order.
The fix changes notification (messages like
session/update) processing from concurrent goroutine spawning to a serial queue.