Skip to content

fix: fix resize scrolling issue #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

fix: fix resize scrolling issue #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions chat/src/components/message-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,6 @@ interface MessageListProps {

export default function MessageList({ messages }: MessageListProps) {
const scrollAreaRef = useRef<HTMLDivElement>(null);
// Avoid the message list to change its height all the time. It causes some
// flickering in the screen because some messages, as the ones displaying
// progress statuses, are changing the content(the number of lines) and size
// constantily. To minimize it, we keep track of the biggest scroll height of
// the content, and use that as the min height of the scroll area.
const contentMinHeight = useRef(0);

// Track if user is at bottom - default to true for initial scroll
const isAtBottomRef = useRef(true);
Expand Down Expand Up @@ -67,11 +61,6 @@ export default function MessageList({ messages }: MessageListProps) {
const isNewUserMessage =
messages.length > 0 && messages[messages.length - 1].role === "user";

// Update content min height if needed
if (currentScrollHeight > contentMinHeight.current) {
contentMinHeight.current = currentScrollHeight;
}

// Auto-scroll only if:
// 1. It's the first render, OR
// 2. There's new content AND user was at the bottom, OR
Expand Down Expand Up @@ -104,9 +93,7 @@ export default function MessageList({ messages }: MessageListProps) {
return (
<div className="overflow-y-auto flex-1" ref={scrollAreaRef}>
<div
className="p-4 flex flex-col gap-4 max-w-4xl mx-auto"
style={{ minHeight: contentMinHeight.current }}
>
className="p-4 flex flex-col gap-4 max-w-4xl mx-auto transition-all duration-300 ease-in-out min-h-0">
{messages.map((message) => (
<div
key={message.id ?? "draft"}
Expand Down