Conversation
hugodutka
force-pushed
the
hugodutka/env-vars
branch
from
578390d to
d9066a9
Compare
johnstcn
reviewed
Aug 5, 2025
Member
johnstcn
left a comment
johnstcn
left a comment
There was a problem hiding this comment.
Can we add some tests around the CLI / env parsing and precedence in e.g. server_test.go?
Suggest:
- All args
- All env
- Args vs Env precedence
johnstcn
approved these changes
Aug 5, 2025
cmd/server/server_test.go
Outdated
Comment on lines
267
to
270
| os.Setenv("AGENTAPI_TYPE", "goose") | ||
| os.Setenv("AGENTAPI_TERM_WIDTH", "120") | ||
| defer os.Unsetenv("AGENTAPI_TYPE") | ||
| defer os.Unsetenv("AGENTAPI_TERM_WIDTH") |
8 tasks
hugodutka
force-pushed
the
hugodutka/env-vars
branch
from
5deeb8a to
4d2eeb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow configuring AgentAPI using environment variables. At the same time, I also refactored
httpapi.NewServerto accept a struct config instead of positional arguments, because I noticed it's getting crowded.