Skip to content

feat: update support for codex cli #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 11, 2025
Merged

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Aug 11, 2025

  • support codex cli v0.20.0

- support codex xli v0.20.0
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 11, 2025

@hugodutka @matifali PR ready for review

@matifali matifali requested review from hugodutka and Copilot August 11, 2025 13:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the msgfmt library to support Codex CLI v0.20.0 by updating test data and message formatting logic to match the new interface format.

  • Updates test data files to reflect new Codex CLI output format with simplified welcome message and different status indicators
  • Simplifies the Codex message formatting function by removing legacy message box handling and implementing new input box removal logic
  • Removes a specific term height limitation for Codex that is no longer needed

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/msgfmt/testdata/format/codex/*/user.txt Updates user input test cases with new question formats
lib/msgfmt/testdata/format/codex/*/msg.txt Updates raw message format to match new Codex CLI v0.20.0 output
lib/msgfmt/testdata/format/codex/*/expected.txt Updates expected formatting results for new Codex interface
lib/msgfmt/msgfmt.go Simplifies formatCodexMessage function by removing legacy message box handling
lib/msgfmt/message_box.go Refactors removeCodexMessageBox to removeCodexInputBox with updated logic for new format
cmd/server/server.go Removes Codex-specific terminal height limitation workaround

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Aug 11, 2025

@hugodutka resolved all.

@hugodutka hugodutka merged commit 797a81e into coder:main Aug 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants