-
Notifications
You must be signed in to change notification settings - Fork 7
Migrate the Frontend Coder Plugin to NFS #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Camila Belo <[email protected]>
Signed-off-by: Camila Belo <[email protected]>
Signed-off-by: Camila Belo <[email protected]>
Signed-off-by: Camila Belo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is used by "msw" to intercept requests that should be mocked by the Backstage dev app, such as requests to Coder Proxy API. The mock service worker needs to be in this "public" folder so that the Backstage CLI can find it and serve it at localhost:3000/mockServiceWorker.js.
| factory(originalFactory, context) { | ||
| const { defaultQueryFilter, readEntityData } = context.config; | ||
| return originalFactory({ | ||
| filter: { kind: 'component' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This filter specifies that the card should be displayed for all entities of the component kind. Is there any specific entity spec that must also be present in the entity data for the card to be displayed?
Signed-off-by: Camila Belo <[email protected]>
|
@camilaibs Terribly sorry for the late reply and follow-up, but I'm hoping to go through the PR this week. Just getting back up to speed on everything as Coder works to start supporting the plugin more directly |
| @@ -0,0 +1,9 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilaibs I'm getting ready to start the review in earnest, but I did have two questions about the changes being made to the repo.
From my understanding, Backstage introduced this Yarn plugin to make it simpler for Backstage users to ensure that their various dependencies are in sync with the Backstage mainline versions. And also, this got added around the middle of last year (probably around the time development slowed for this plugin the first time around). A key part of that is specifying Backstage versions like this:
"@backstage/core-compat-api": "backstage:^",- Is there anything that needs to change from the plugin authoring standpoint to make sure that we're a little bit more insulated from Backstage version changes and breaking API changes?
- We're looking into reports from some potential customers, and they've said the current version of the plugin (based on
1.22) is breaking for later versions of Backstage (at least1.43). We're still gathering information from them, but they've made it sound that it was the upgrade process that broke things. I assume the NFS helps with this a lot, but is there anything else we can do to maximize compatibility? I don't want to force consumers to update their Backstage deployment to continue using the plugin, when I don't know what red tape various companies have to deal with
- We're looking into reports from some potential customers, and they've said the current version of the plugin (based on
- With the updates that have been made so far, it looks like they've all been centered on updating the dev page, as well as getting the plugin moved to NFS. Does the PR still need to update the
packagesdirectory to keep those in sync with the new Backstage version?
Description
This pull request migrates the Coder frontend plugin to support the new Backstage frontend system.
After merging this pull request it would be nice to: