dependency inject stdio from serpent cli #21
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcpeinhardt
commented
Sep 11, 2025
cli/cli.go
Outdated
|
|
||
| // Run executes the jail command with the given configuration and arguments | ||
| func Run(config Config, args []string) error { | ||
| func Run(config Config, stdin io.Reader, stdout, stderr io.Writer, args []string) error { |
There was a problem hiding this comment.
I suppose these should go in the config
|
You know what... I'll come back to this 💀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the stdio values were being hardcoded by platform. This PR injects the stdio values from the serpent CLI instead, enabling E2E testing of the CLI with a MockPTY as well as being the more correct solution for integrating into coder.