Migrate environment variable reads to CLI package #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so-v1[bot]](https://avatars.githubusercontent.com/in/1271127?s=80&v=4){kind=small}
Moved all os.Getenv() calls to the CLI package and pass environment variables as parameters to components that need them. This centralizes environment variable access and makes the code more testable. Changes: - Updated CLI package to read all environment variables directly - Modified TLS, jail, and namespace packages to accept env config - Removed all os.Getenv() calls from non-CLI packages - Updated function signatures across all affected components - Fixed stub files for cross-platform compatibility Co-authored-by: f0ssel <[email protected]>
Centralized environment variable reading and processing logic into a single function that returns a SudoData struct with both raw and processed values. Improvements: - Created SudoData struct with raw env vars and processed values - Added readSudoData() function that handles all sudo-related logic - Centralized user lookup, UID/GID parsing, and error handling - Eliminated duplicate os.Getenv() calls throughout the code - Added proper logging for sudo environment processing - Made the code more testable and maintainable All environment variable reads are now in a single location with consistent error handling and logging. Co-authored-by: f0ssel <[email protected]>
Simplified the codebase by converting string environment variables to integers once in readSudoData() and using integers throughout instead of converting back and forth between strings and integers. Changes: - Removed raw string fields from SudoData struct - Updated all EnvConfig structs to use integers for UID/GID - Eliminated string parsing in TLS, jail, and namespace packages - Removed unnecessary strconv imports - Simplified credential handling by working with integers directly - Maintained centralized environment variable reading in CLI package All environment variable processing now happens once in readSudoData(), with processed integer values used throughout the codebase. Co-authored-by: f0ssel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrated all environment variable reads to the CLI package and centralized the processing logic. This improves code organization, testability, and eliminates redundant parsing throughout the codebase.
Changes
Environment Variable Centralization
os.Getenv()calls to CLI package: All environment variable reads now happen in a single locationSudoDatastruct: Holds processed environment data with both raw and computed valuesreadSudoData()function: Centralizes environment variable reading, parsing, and validationInteger-Based Processing
readSudoData()and used as integers throughoutstrconv.Atoi()calls from TLS, jail, and namespace packagesstringtointacross all packagesCode Organization
EnvConfigparameters instead of reading environment variables directlyToTLSEnvConfig()andToJailEnvConfig()for clean data conversionstrconvimports where no longer neededEnvironment Variables Handled
SUDO_USER- Original username when running under sudoSUDO_UID- Original user ID (parsed to int)SUDO_GID- Original group ID (parsed to int)XDG_CONFIG_HOME- XDG config directory pathTesting
Benefits