fix: drop privileges to original user when running with sudo #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When jail is executed with
sudo
, the subprocess runs as root instead of the original user:sudo jail -- whoami # Returns "root" instead of original username
This causes issues because:
Solution
This PR implements privilege dropping to make the subprocess run as the original user when jail is executed with sudo.
Implementation
Clean and Minimal Approach:
Linux (
network/linux.go
):SUDO_UID
/SUDO_GID
environment variablessyscall.Credential
to set subprocess UID/GIDmacOS (
network/macos.go
):Usage
Testing
The implementation has been tested to ensure:
Benefits