e2e tests #60
Merged
e2e tests #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-scherbina
force-pushed
the
yevhenii/proxy-tests
branch
4 times, most recently
from
cacd25c to
973ca20
Compare
evgeniy-scherbina
force-pushed
the
yevhenii/proxy-tests
branch
from
917660d to
3bc6cdf
Compare
bcpeinhardt
approved these changes
Sep 24, 2025
| } | ||
|
|
||
| // TODO: clean up this rules | ||
| cmd = exec.Command("iptables", "-A", "FORWARD", "-s", "192.168.100.0/24", "-j", "ACCEPT") |
There was a problem hiding this comment.
I think some additional documentation explaining this would be really good
There was a problem hiding this comment.
agree, I'll do it in a follow-up PR
| @@ -0,0 +1,69 @@ | |||
| package util | |||
There was a problem hiding this comment.
I don't really like having a util package, ideally we won't keep it for long
There was a problem hiding this comment.
yes, I wasn't sure what the better option for now to make test work
But I'll refactor it later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #62