Fix goroutine leaks in CONNECT connection handling #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The proxy was building up CPU and memory usage over time due to goroutine leaks in CONNECT connection handling. Three specific leaks were identified:
Solution
The errgroup ensures that:
Testing
✅ All existing tests pass
✅ Code compiles without errors
Changes
golang.org/x/sync/errgroup
dependencystreamRequestToTarget
to use errgroup with 3 goroutines (request copy, response copy, cleanup monitor)handleConnectStreaming
to use errgroup with 3 goroutines (client→target, target→client, cleanup monitor)