🤖 fix: make Review tab toggles global instead of per-workspace #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed 'Show Read' and 'Uncommitted' toggles to use global storage
keys instead of workspace-specific keys. These settings should apply
across all workspaces rather than being configured separately for each.
- Changed `review-include-uncommitted:${workspaceId}` to `review-include-uncommitted`
- Changed `review-show-read:${workspaceId}` to `review-show-read`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Show Read' and 'Uncommitted' toggles in the Review tab were stored per-workspace, requiring users to configure them separately for each workspace. This changes them to global settings that apply across all workspaces.
Changes:
review-include-uncommitted:${workspaceId}→review-include-uncommittedreview-show-read:${workspaceId}→review-show-readUsers' preferences for these toggles will now persist when switching between workspaces.
Generated with
cmux