Skip to content

fix(artifactory): ignore extensions without a manifest #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix(artifactory): ignore extensions without a manifest #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion storage/artifactory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
return err
} else if err != nil {
id := ExtensionID(ext.publisher, ext.name, ext.versions[0].Version)
s.logger.Error(ctx, "Unable to read extension manifest", slog.Error(err),
s.logger.Error(ctx, "Unable to read extension manifest; extension will be ignored", slog.Error(err),
slog.F("id", id),
slog.F("targetPlatform", ext.versions[0].TargetPlatform))
} else {
Expand All @@ -405,6 +405,9 @@ func (s *Artifactory) WalkExtensions(ctx context.Context, fn func(manifest *VSIX
return err
}
for _, ext := range extensions {
if ext.manifest == nil {
continue
}
if err = fn(ext.manifest, ext.versions); err != nil {
return err
}
Expand Down
Loading