chore: staple empty signatures #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since signatures are not checked, or not valid (static public key in VSCode), then signing is just incorrect.
code-asher
approved these changes
Dec 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since signatures are not checked, or not valid (static public key in VSCode), then signing is just incorrect.
This will work for code-server, VSCodium, VSCode on linux. It will not work on VSCode for windows.
See linux check: https://github.com/microsoft/vscode/blob/65edc4939843c90c34d61f4ce11704f09d3e5cb6/src/vs/platform/extensionManagement/node/extensionManagementService.ts#L353 (
!isLinux)Signing work
All signing work is in branch
stevenmasley/cms_sign.