Skip to content

chore(#94): allow specifying other custom volumes #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions helm/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,17 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
serviceAccountName: {{ include "code-marketplace.serviceAccountName" . }}
{{- if not .Values.persistence.artifactory.enabled }}
{{- if or (.Values.volumes) (not .Values.persistence.artifactory.enabled) }}
volumes:
{{- if not .Values.persistence.artifactory.enabled }}
- name: extensions
persistentVolumeClaim:
claimName: {{ include "code-marketplace.fullname" . }}
{{- end }}
{{- with .Values.volumes }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- end }}
securityContext:
{{- toYaml .Values.podSecurityContext | nindent 8 }}
containers:
Expand Down Expand Up @@ -63,11 +68,16 @@ spec:
- --extensions-dir
- /extensions
{{- end }}
{{- if not .Values.persistence.artifactory.enabled }}
{{- if or (.Values.volumeMounts) (not .Values.persistence.artifactory.enabled) }}
volumeMounts:
{{- if not .Values.persistence.artifactory.enabled }}
- name: extensions
mountPath: /extensions
{{- end }}
{{- with .Values.volumeMounts }}
{{- toYaml . | nindent 12 }}
{{- end }}
{{- end }}
livenessProbe:
httpGet:
path: /healthz
Expand Down
13 changes: 13 additions & 0 deletions helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,19 @@ autoscaling:
targetCPUUtilizationPercentage: 80
# targetMemoryUtilizationPercentage: 80

# Additional volumes on the output Deployment definition.
volumes: []
# - name: foo
# secret:
# secretName: mysecret
# optional: false

# Additional volumeMounts on the output Deployment definition.
volumeMounts: []
# - name: foo
# mountPath: "/etc/foo"
# readOnly: true

nodeSelector: {}

tolerations: []
Expand Down
Loading