feat: send push notifications on VPN failures #196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ethanndickson
force-pushed
the
ethan/push-notif-vpn-failure
branch
from
3172ac2 to
4a6433a
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds user-facing push notifications when the VPN or URI handler fails, and refactors notification setup and handling into the AppDelegate.
- Bumps the
fluid-menu-bar-extradependency revision. - Sends a
.vpnFailurenotification on VPN state failures. - Refactors
UNUserNotificationCenterdelegate logic intoAppDelegate, registers categories, and updatessendNotification.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Coder-Desktop/project.yml | Updated fluid-menu-bar-extra revision |
| Coder-Desktop/Coder-Desktop/VPN/VPNService.swift | Send push notification on VPN failures |
| Coder-Desktop/Coder-Desktop/Notifications.swift | Moved delegate into AppDelegate, added categories and NotificationCategory enum, updated sendNotification signature |
| Coder-Desktop/Coder-Desktop/Coder_DesktopApp.swift | Call new category registration, set delegate to self, update URI failure call |
| @@ -1,8 +1,23 @@ | |||
| import UserNotifications | |||
There was a problem hiding this comment.
The old NotifDelegate class was removed but I don’t see its full definition cleaned up. Please remove any leftover NotifDelegate declaration to avoid dead code.
| nonisolated func userNotificationCenter( | ||
| _: UNUserNotificationCenter, | ||
| willPresent _: UNNotification | ||
| ) async -> UNNotificationPresentationOptions { |
There was a problem hiding this comment.
Ensure the userNotificationCenter(_:willPresent:withCompletionHandler:) method is inside the AppDelegate extension so banners still appear while the app is active.
|
Might come back to this later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #195.
When the macOS VPN unexpectedly disconnects, Coder Connect currently just displays a red error message:
Now, when this happens, we'll additionally send a push notification with the same message:
The above error message was produced by force quitting the system extension.
Clicking these VPN failure notifications also opens the tray:
notifdemo.mov
Once coder/coder#18602 is closed, we can also send push notifications when Coder Connect disconnects / attempts to dial the Coder deployment. We currently do not support being notified of these events.