Skip to content

chore: improve text contrast on light mode #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2025
Merged

chore: improve text contrast on light mode #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Coder Desktop/Coder Desktop/VPNMenuState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ enum AgentStatus: Int, Equatable, Comparable {
case .okay: .green
case .warn: .yellow
case .error: .red
case .off: .gray
case .off: .secondary
}
}

Expand Down
4 changes: 2 additions & 2 deletions Coder Desktop/Coder Desktop/Views/Agents.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ struct Agents<VPN: VPNService>: View {
if items.count == 0 {
Text("No workspaces!")
.font(.body)
.foregroundColor(.gray)
.foregroundColor(.secondary)
.padding(.horizontal, Theme.Size.trayInset)
.padding(.top, 2)
}
Expand All @@ -30,7 +30,7 @@ struct Agents<VPN: VPNService>: View {
Toggle(isOn: $viewAll) {
Text(viewAll ? "Show less" : "Show all")
.font(.headline)
.foregroundColor(.gray)
.foregroundColor(.secondary)
.padding(.horizontal, Theme.Size.trayInset)
.padding(.top, 2)
}.toggleStyle(.button).buttonStyle(.plain)
Expand Down
2 changes: 1 addition & 1 deletion Coder Desktop/Coder Desktop/Views/VPNMenu.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ struct VPNMenu<VPN: VPNService>: View {
Divider()
Text("Workspaces")
.font(.headline)
.foregroundColor(.gray)
.foregroundColor(.secondary)
VPNState<VPN>()
}.padding([.horizontal, .top], Theme.Size.trayInset)
Agents<VPN>()
Expand Down
2 changes: 1 addition & 1 deletion Coder Desktop/Coder Desktop/Views/VPNMenuItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ struct MenuItemView: View {
var formattedName = AttributedString(name)
formattedName.foregroundColor = .primary
if let range = formattedName.range(of: ".coder") {
formattedName[range].foregroundColor = .gray
formattedName[range].foregroundColor = .secondary
}
return formattedName
}
Expand Down
6 changes: 3 additions & 3 deletions Coder Desktop/Coder Desktop/Views/VPNState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ struct VPNState<VPN: VPNService>: View {
case (.failed(.systemExtensionError(.needsUserApproval)), _):
Text("Awaiting System Extension approval")
.font(.body)
.foregroundStyle(.gray)
.foregroundStyle(.secondary)
case (_, false):
Text("Sign in to use CoderVPN")
.font(.body)
.foregroundColor(.gray)
.foregroundColor(.secondary)
case (.disabled, _):
Text("Enable CoderVPN to see workspaces")
.font(.body)
.foregroundStyle(.gray)
.foregroundStyle(.secondary)
case (.connecting, _), (.disconnecting, _):
HStack {
Spacer()
Expand Down
Loading