Skip to content

fix: change dummy workspace logic to include starting and stopping #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

fix: change dummy workspace logic to include starting and stopping #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion App/ViewModels/TrayWindowViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ private void UpdateFromRpcModel(RpcModel rpcModel)
// For every stopped workspace that doesn't have any agents, add a
// dummy agent row.
foreach (var workspace in rpcModel.Workspaces.Where(w =>
w.Status == Workspace.Types.Status.Stopped && !workspacesWithAgents.Contains(w.Id)))
ShouldShowDummy(w) && !workspacesWithAgents.Contains(w.Id)))
{
if (!Uuid.TryFrom(workspace.Id.Span, out var uuid))
continue;
Expand Down Expand Up @@ -372,4 +372,21 @@ public void Exit()
{
_ = ((App)Application.Current).ExitApplication();
}

private static bool ShouldShowDummy(Workspace workspace)
{
switch (workspace.Status)
{
case Workspace.Types.Status.Unknown:
case Workspace.Types.Status.Pending:
case Workspace.Types.Status.Starting:
case Workspace.Types.Status.Stopping:
case Workspace.Types.Status.Stopped:
return true;
// TODO: should we include and show a different color than Gray for workspaces that are
// failed, canceled or deleting?
default:
return false;
}
}
}
Loading