Skip to content

fix: add scrollviewer around the connect error display #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 20, 2025
Merged

fix: add scrollviewer around the connect error display #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4fae09e
fix: add scrollviewer around the connect error display to prevent ove…
ibetitsmike Oct 17, 2025
0aa1ca5
fix: added selectable property in multiple error displays
ibetitsmike Oct 20, 2025
5b187f8
Apply suggestion from @deansheather
ibetitsmike Oct 20, 2025
a7a4576
Apply suggestion from @deansheather
ibetitsmike Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions App/Views/Pages/DirectoryPickerMainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
<ScrollView Grid.Row="0">
<TextBlock
Margin="0,0,0,20"
IsTextSelectionEnabled="True"
Foreground="Red"
TextWrapping="Wrap"
Text="{x:Bind ViewModel.InitialLoadError, Mode=OneWay}" />
Expand Down
1 change: 1 addition & 0 deletions App/Views/Pages/FileSyncListMainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
<TextBlock
Margin="0,0,0,20"
Foreground="Red"
IsTextSelectionEnabled="True"
TextWrapping="Wrap"
Text="{x:Bind ViewModel.Error, Mode=OneWay}" />
</ScrollView>
Expand Down
1 change: 1 addition & 0 deletions App/Views/Pages/SignInUrlPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
<TextBlock
Grid.Column="1"
Grid.Row="1"
IsTextSelectionEnabled="True"
Text="{x:Bind ViewModel.CoderUrlError, Mode=OneWay}"
Foreground="Red" />
</Grid>
Expand Down
1 change: 1 addition & 0 deletions App/Views/Pages/TrayWindowDisconnectedPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
TextWrapping="Wrap"
Margin="0,0,0,10"
Foreground="Red"
IsTextSelectionEnabled="True"
Text="{x:Bind ViewModel.ErrorMessage, Mode=OneWay}" />
</ScrollViewer>

Expand Down
17 changes: 11 additions & 6 deletions App/Views/Pages/TrayWindowMainPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,18 @@

<controls:HorizontalRule />

<TextBlock
Text="{x:Bind ViewModel.VpnFailedMessage, Mode=OneWay}"
Foreground="Red"
Margin="0,6,0,6"
TextWrapping="Wrap"
Visibility="{x:Bind ViewModel.ShowFailedSection, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}" />
<ScrollViewer
VerticalScrollBarVisibility="Auto"
MaxHeight="500"
Visibility="{x:Bind ViewModel.ShowFailedSection, Converter={StaticResource BoolToVisibilityConverter}, Mode=OneWay}" >

<TextBlock
Text="{x:Bind ViewModel.VpnFailedMessage, Mode=OneWay}"
Foreground="Red"
IsTextSelectionEnabled="True"
Margin="0,6,0,6"
TextWrapping="Wrap" />
</ScrollViewer>
<TextBlock
Text="Enable Coder Connect to view your workspaces."
TextWrapping="Wrap"
Expand Down
Loading