fix: override default delete confirmation dialog #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- right now there are two confirmation dialogs when removing a workspace from Toolbox - with this patch we force Toolbox to discard its default dialog and show a custom one with the Coder titles and messages.
- no longer valid after delete confirmation dialog is using the new api
- workspace status is usually updated every 5 seconds by the polling loop. - that's a bit problematic because when we delete a workspace we have to wait a couple of seconds until we have some visual feedback. - with this patch we force the workspace status to be in "deleting" if the REST api call was succesfull.
- right now we depend on the underlying okhttp/moshi marshaller on which order the workspaces are listed. - instead we can sort them by name and guarantee some consistency
matifali
approved these changes
Apr 3, 2025
fioan89
added a commit
that referenced
this pull request
Aug 11, 2025
When the plugin is upgraded while JBClient is connected to a remote dev server via the Coder SSH proxy/tunnel, the upgrade process kills and re-establishes the SSH connection. However, JBClient/Toolbox fails to detect the restored connection and reports "Toolbox: Target environment com.coder.toolbox:bobiverse-bob.dev not found" error. While digging into the Toolbox bytecode—specifically `ClientOverSshTunnelConnector` — I realized the issue likely stems from an incorrect equals implementation in our custom SSH connection info object. In short, when a plugin upgrade terminates the SSH tunnel, the connector’s monitoring logic correctly detects the lost connection and waits. But when the SSH connection is re-established, the monitoring logic fails to recognize it as a valid replacement, because equals is still using the default `Object#equals` rather than a proper value-based implementation. Unfortunately, I wasn’t able to properly test this—specifically, upgrading from a version without the fix to one that includes it—because all Toolbox marketplace feeds are signed, preventing us from using a tool like mitmproxy to serve a locally modified plugin version. Given that, I propose releasing the change first and then performing the upgrade test to confirm the fix. - resolves #61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now there are two confirmation dialogs when removing a workspace from Toolbox
with this patch we force Toolbox to discard its default dialog and show a custom one with
the Coder titles and messages.
resolves There are two confirmation dialogs shown when deleting a workspace #60