Skip to content

Conversation

@ncoop57
Copy link

@ncoop57 ncoop57 commented Jan 14, 2026

Problem

The cursorAccent theme property was defined in xtermjs' ITheme but never actually used. Block cursors rendered as opaque rectangles that completely cover the character underneath, making it invisible.

Solution

  • Added optional colorOverride parameter to renderCellText()
  • After drawing the block cursor, re-render the cell's text using cursorAccent as the color override

This is a minimal change that reuses the existing text rendering logic, ensuring proper handling of font styles, graphemes, and wide characters.

PR created with the assistance of SolveIT, manually reviewed, iterated, and tested personally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant