Fix block cursor to render text with cursorAccent color #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
cursorAccenttheme property was defined in xtermjs'IThemebut never actually used. Block cursors rendered as opaque rectangles that completely cover the character underneath, making it invisible.Solution
colorOverrideparameter torenderCellText()cursorAccentas the color overrideThis is a minimal change that reuses the existing text rendering logic, ensuring proper handling of font styles, graphemes, and wide characters.
PR created with the assistance of SolveIT, manually reviewed, iterated, and tested personally.