Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

chore: cleanup all test files #293

Merged
merged 4 commits into from
Sep 27, 2024
Merged

chore: cleanup all test files #293

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a6f1405
chore: cleanup imports and value declarations for tests
Parkreiner Sep 20, 2024
f852190
fix: update types for test.ts
Parkreiner Sep 20, 2024
324966e
Merge branch 'main' into mes/quick-cleanup
Parkreiner Sep 27, 2024
6b09b60
fix: resolve module config mismatch
Parkreiner Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jfrog-oauth/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ EOF`;
const proxies = ["foo", "bar", "baz"]
.map((r) => `https://${user}:@${fakeFrogApi}/go/${r}`)
.join(",");
expect(proxyEnv["value"]).toEqual(proxies);
expect(proxyEnv.value).toEqual(proxies);

const coderScript = findResourceInstance(state, "coder_script");
expect(coderScript.script).toContain(
Expand Down
2 changes: 1 addition & 1 deletion jfrog-token/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ EOF`;
const proxies = ["foo", "bar", "baz"]
.map((r) => `https://${user}:${token}@${fakeFrogApi}/go/${r}`)
.join(",");
expect(proxyEnv["value"]).toEqual(proxies);
expect(proxyEnv.value).toEqual(proxies);

const coderScript = findResourceInstance(state, "coder_script");
expect(coderScript.script).toContain(
Expand Down
10 changes: 7 additions & 3 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
{
"compilerOptions": {
"target": "esnext",
"module": "nodenext",
// If we were just compiling for the tests, we could safely target ESNext at
// all times, but just because we've been starting to add more runtime logic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have the runtime logic in the windows-rdp module, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, yeah

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But one of the other benefits of having an older compilation target is that, because I have that JavaScript file set up to be part of the TypeScript project, the TypeScript LSP can catch any function calls that might be using features that are too recent

// files to some of the modules, erring on the side of caution by having a
// older compilation target
"target": "ES6",
"module": "ESNext",
"strict": true,
"allowSyntheticDefaultImports": true,
"moduleResolution": "nodenext",
"moduleResolution": "node",
"types": ["bun-types"]
}
}