This repository was archived by the owner on May 15, 2025. It is now read-only.
feat: ci to build new registry on push to main #363
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| #!/usr/bin/env bash | ||
| set -o pipefail | ||
| set -u | ||
|
|
||
| VERBOSE="${VERBOSE:-0}" | ||
| if [[ "${VERBOSE}" -ne "0" ]]; then | ||
| set -x | ||
| fi | ||
|
|
||
| # List of required environment variables | ||
| required_vars=( | ||
| "GCLOUD_API_KEY" | ||
| "GCLOUD_PROD_DEPLOY_SECRET" | ||
| "GCLOUD_DEV_DEPLOY_SECRET" | ||
| ) | ||
|
|
||
| # Check if each required variable is set | ||
| for var in "${required_vars[@]}"; do | ||
| if [[ -z "${!var:-}" ]]; then | ||
| echo "Error: Environment variable '$var' is not set." | ||
| exit 1 | ||
| fi | ||
| done | ||
|
|
||
| # Trigger a build for dev | ||
| # DONT EVER SET ANY FLAGS THAT MIGHT PRINT THE URL, AS IT HAS SECRETS IN IT | ||
| curl -X POST "https://cloudbuild.googleapis.com/v1/projects/coder-registry-1/triggers/http-build-registry-v2-dev:webhook?key=${GCLOUD_API_KEY}&secret=${GCLOUD_DEV_DEPLOY_SECRET}" \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{}' \ | ||
| --fail | ||
|
|
||
| # Trigger a build for prod | ||
| # DONT EVER SET ANY FLAGS THAT MIGHT PRINT THE URL, AS IT HAS SECRETS IN IT | ||
| curl -X POST "https://cloudbuild.googleapis.com/v1/projects/coder-registry-1/triggers/http-build-registry-v2-trigger:webhook?key=${GCLOUD_API_KEY}&secret=${GCLOUD_PROD_DEPLOY_SECRET}" \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{}' \ | ||
| --fail | ||
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: deploy-registry | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| pull_request: | ||
|
||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| deploy: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Run deploy-registry.sh | ||
| run: | | ||
| ./.github/scripts/deploy-registry.sh | ||
| env: | ||
| GCLOUD_API_KEY: ${{ secrets.GCLOUD_API_KEY }} | ||
| GCLOUD_PROD_DEPLOY_SECRET: ${{ secrets.GCLOUD_PROD_DEPLOY_SECRET }} | ||
| GCLOUD_DEV_DEPLOY_SECRET: ${{ secrets.GCLOUD_DEV_DEPLOY_SECRET }} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely convinced about this approach. We could maybe instead trigger a build using the
gcloudCLI (ref: https://cloud.google.com/sdk/gcloud/reference/builds/triggers/run) in combination with thesetup-gcloudaction (https://github.com/google-github-actions/setup-gcloud)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @deansheather for some additional eyes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely would prefer to use gcloud CLI rather than calling googleapis from curl. We also should not be using service account credentials as actions secrets, and should use workload identity instead. I can help you set that up with a new SA for this repo @bcpeinhardt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secrets deleted, will update to use the gcloud cli, and yes some help with a service account would be great haha 😎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll message you on Slack