Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 16, 2024

Bumps crate-ci/typos from 1.17.2 to 1.28.4.

Release notes

Sourced from crate-ci/typos's releases.

v1.28.4

[1.28.4] - 2024-12-16

Features

  • --format sarif support

v1.28.3

[1.28.3] - 2024-12-12

Fixes

  • Correct imlementations, includs, qurorum, transatctions, trasnactions, validasted, vview

v1.28.2

[1.28.2] - 2024-12-02

Fixes

  • Don't correct parametrize variants

v1.28.1

[1.28.1] - 2024-11-26

Fixes

  • Add back in lock file types accidentally removed in 1.28 (go.sum, requirements.txt)

v1.28.0

[1.28.0] - 2024-11-25

Features

  • Updated the dictionary with the November 2024 changes
  • Add many new types and file extensions to the --type-list, including ada, alire, bat, candid, carp, cml, devicetree, dita, dockercompose, grpbuild, graphql, hare, lean, meson, prolog, raku, reasonml, rescript, solidity, svelte, usd, v, wgsl

v1.27.3

[1.27.3] - 2024-11-08

Fixes

  • Don't correct alloced
  • Don't correct registor, a more domain specific variant of register

v1.27.2

[1.27.2] - 2024-11-06

Fixes

  • Correct fand

... (truncated)

Changelog

Sourced from crate-ci/typos's changelog.

[1.28.4] - 2024-12-16

Features

  • --format sarif support

[1.28.3] - 2024-12-12

Fixes

  • Correct imlementations, includs, qurorum, transatctions, trasnactions, validasted, vview

[1.28.2] - 2024-12-02

Fixes

  • Don't correct parametrize variants

[1.28.1] - 2024-11-26

Fixes

  • Add back in lock file types accidentally removed in 1.28 (go.sum, requirements.txt)

[1.28.0] - 2024-11-25

Features

  • Updated the dictionary with the November 2024 changes
  • Add many new types and file extensions to the --type-list, including ada, alire, bat, candid, carp, cml, devicetree, dita, dockercompose, grpbuild, graphql, hare, lean, meson, prolog, raku, reasonml, rescript, solidity, svelte, usd, v, wgsl

[1.27.3] - 2024-11-08

Fixes

  • Don't correct alloced
  • Don't correct requestor, a more domain specific variant of requester

[1.27.2] - 2024-11-06

Fixes

  • Correct fand

[1.27.1] - 2024-11-06

Fixes

  • Correct alingment as alignment, rather than alinement

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.17.2 to 1.28.4.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.17.2...v1.28.4)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 16, 2024
@matifali
Copy link
Member

@phorcys420 could you check this once you have some time? this has bee lingering now for many months.

@phorcys420
Copy link
Member

@matifali I think this is due to the fact that the new version detects more typos and generates a false positive.
See https://github.com/coder/modules/pull/367/files#annotation_29849547527

The issue is that I'm not sure what we should do to fix it, we can either:

  • Ignore that false positive (but then if we type "muc" instead of "much" it won't be detected)
  • Ignore that file (but then any other typos in the file won't be detected)

The issue with this module is that it doesn't seem to support ignoring via comments like ESLint or Prettier so you can't just ignore a single line/block.
What do you think?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 6, 2025

Superseded by #381.

@dependabot dependabot bot closed this Jan 6, 2025
@dependabot dependabot bot deleted the dependabot/github_actions/crate-ci/typos-1.28.4 branch January 6, 2025 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants