Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

Conversation

@matifali
Copy link
Member

@matifali matifali commented Apr 22, 2025

This pull request updates the GitHub Actions workflow to enhance deployment flexibility by allowing it to trigger on specific tag patterns in addition to pushes to the main branch.

Workflow trigger update:

@matifali matifali requested review from bcpeinhardt and f0ssel April 22, 2025 17:21
@bcpeinhardt
Copy link
Collaborator

Nit: I think we'll have quite a few started and cancelled builds, where a tag is pushed just after a merge.

@matifali
Copy link
Member Author

matifali commented Apr 22, 2025

Nit: I think we'll have quite a few started and cancelled builds, where a tag is pushed just after a merge.

We do not have any concurrency settings, so by default, all workflow runs run concurrently.

How do we fetch tags (is it git fetch --force --tags) during the build process? I don't want the latest pushed tag to an older commit to somehow exclude all later tags from the latest commit.

Without proper concurrency settings, module tags pushed to older commits can cause build issues:

A --- B --- C --- D  ← Main branch 
      ↑     ↑     ↑
      |     |     |
module-a/v1.0.21  module-b/v1.2.0
            |
            ↓
      module-a/v1.1.0
      (pushed later to an older commit)

Would this new tag (module-a/v1.1.0) pushed to an older commit cause the newer commit tag (module-b/v1.2.0) to be excluded from the latest build?

@matifali matifali changed the title ci: deploy on tag pushes ci: deploy dev registry on tag pushes Apr 22, 2025
@bcpeinhardt
Copy link
Collaborator

No there wouldn't be any issues here. The release tag just says "the source for version vX.Y.Z of this module comes from this commit". It is completely valid for an older commit to be used as the source of truth for a newer version of a module.
There shouldn't be concurrency issues with fetching tags or anything either. The entire repo is cloned and all tags are present for every build.

@matifali matifali merged commit 4b4ceba into main Apr 22, 2025
4 checks passed
@matifali matifali deleted the deploy-on-tag branch April 22, 2025 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants