This repository was archived by the owner on May 15, 2025. It is now read-only.
feat: support path sharing for KasmVNC module #459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrycub
changed the title
matifali
reviewed
May 5, 2025
There was a problem hiding this comment.
Could you bump the version in README.md by 1 minor version? Thanks.
|
We are moving to https://github.com/coder/regitsry. Please move your PR there. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates to enhance the KasmVNC module, including improved configuration flexibility, better error handling, and support for path-based sharing. Key changes include the addition of a
subdomainvariable, restructuring of the Terraform configuration, and significant updates to therun.shscript for better logging and robustness.Enhancements to Terraform Configuration:
subdomainvariable invariables.tfto enable or disable subdomain support for KasmVNC.main.tfwith alocalsblock for cleaner and more maintainable code.Improvements to the
run.shScript:info,warn,error,debug) for consistent and user-friendly logging.echostatements with the newerrorfunction for critical failures. [1] [2] [3]Support for Path-Based Sharing:
path_vnc.html) to support path-based sharing when subdomains are disabled.run.shto patch KasmVNC webserver files for path-based sharing whensubdomainis set tofalse.Documentation Updates:
README.mdto reflect the newsubdomainvariable and list supported desktop environments.These changes collectively improve the usability, configurability, and robustness of the KasmVNC module.