Skip to content

🤖 fix: use destroy() for splash screen to avoid WebContents race #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ibetitsmike wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

🤖 fix: use destroy() for splash screen to avoid WebContents race #1540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/desktop/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,11 @@ async function showSplashScreen() {
function closeSplashScreen() {
if (splashWindow) {
console.log(`[${timestamp()}] Closing splash screen...`);
splashWindow.close();
const win = splashWindow;
splashWindow = null;
if (!win.isDestroyed()) {
win.destroy(); // Immediate destruction - avoids race with internal renderer scripts
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/node/services/tools/notify.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async function sendElectronNotification(
notification.on("click", () => {
const windows = BrowserWindow.getAllWindows();
const mainWindow = windows[0];
if (mainWindow) {
if (mainWindow && !mainWindow.isDestroyed()) {
// Restore if minimized, then focus
if (mainWindow.isMinimized()) {
mainWindow.restore();
Expand Down
Loading