🤖 fix: improve workspace deletion UX with spinner and idempotency #1610
+26
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show spinner instead of trash icon while deletion is in progress - Expose isRemoving state via API so spinner persists across navigation - Make deletion idempotent: return Ok if already deleting (prevents races) - Add isRemoving field to FrontendWorkspaceMetadata schema
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves workspace deletion UX in the archived workspaces list:
isRemovingvia the workspace list API so the spinner shows even after navigating away and backMotivation
This PR is necessary for the Coder workspace integration, where workspace deletion can take 30+ seconds to several minutes due to remote API calls and cleanup operations. Without this change, users would see a briefly disabled button with no visual feedback, potentially leading to confusion or repeated delete attempts.
Changes
src/node/services/workspaceService.tsisRemoving()method, returnOkwhen already deleting, enrichlist()withisRemovingsrc/common/orpc/schemas/workspace.tsisRemovingfield toFrontendWorkspaceMetadataSchemasrc/browser/components/ArchivedWorkspaces.tsxLoader2spinner when deleting, combine local + API state forisProcessingGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$6.28