🤖 fix: Windows open-in-editor and use deep links for built-in editors #1621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes malformed "Open in Editor" links on Windows and refactors Electron to use deep links for built-in editors.
Problem
vscode://fileC:\...instead ofvscode://file/C:/...)Solution
Deep Link Normalization
normalizeLocalPathForEditorDeepLink()converts\→/and ensures leading/for Windows pathsUnified Editor Launching
window.open()in both Electron and BrowserBackend Simplification
EditorServicenow only handles custom editor commandsCleanup
openInEditorDeepLinkFallback.ts(obsolete with new approach)Files Changed
src/browser/utils/editorDeepLinks.ts- Added path normalizationsrc/browser/utils/openInEditor.ts- Refactored to use deep links for built-in editorssrc/node/services/editorService.ts- Stripped to custom-onlyGenerated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$15.82