Skip to content

Conversation

@ibetitsmike
Copy link
Contributor

@ibetitsmike ibetitsmike commented Jan 14, 2026

Fixes malformed "Open in Editor" links on Windows and refactors Electron to use deep links for built-in editors.

Problem

  • Windows paths were being incorrectly formatted in deep links (vscode://fileC:\... instead of vscode://file/C:/...)
  • Electron and Browser apps had divergent code paths for opening editors

Solution

Deep Link Normalization

  • normalizeLocalPathForEditorDeepLink() converts \/ and ensures leading / for Windows paths

Unified Editor Launching

  • Built-in editors (VS Code, Cursor, Zed): Always use deep links via window.open() in both Electron and Browser
  • Custom editors: Backend spawns the configured command (Electron only)

Backend Simplification

  • EditorService now only handles custom editor commands
  • Removed built-in editor spawning logic from backend

Cleanup

  • Removed openInEditorDeepLinkFallback.ts (obsolete with new approach)

Files Changed

  • src/browser/utils/editorDeepLinks.ts - Added path normalization
  • src/browser/utils/openInEditor.ts - Refactored to use deep links for built-in editors
  • src/node/services/editorService.ts - Stripped to custom-only
  • Tests updated accordingly

Generated with mux • Model: anthropic:claude-opus-4-5 • Thinking: high • Cost: $15.82

@ibetitsmike ibetitsmike force-pushed the mike/fix-windows-deep-editor-links branch 3 times, most recently from 115effb to 9a69395 Compare January 14, 2026 21:29
@ibetitsmike ibetitsmike force-pushed the mike/fix-windows-deep-editor-links branch from 9a69395 to 7f857e7 Compare January 14, 2026 21:50
@ibetitsmike ibetitsmike force-pushed the mike/fix-windows-deep-editor-links branch from 7f857e7 to 95c3b30 Compare January 14, 2026 21:57
@ibetitsmike ibetitsmike enabled auto-merge January 14, 2026 22:03
@ibetitsmike ibetitsmike added this pull request to the merge queue Jan 14, 2026
@ibetitsmike ibetitsmike changed the title 🤖 fix: normalize Windows deep editor links 🤖 fix: Windows open-in-editor and use deep links for built-in editors Jan 14, 2026
Merged via the queue into main with commit 079fb7a Jan 14, 2026
21 checks passed
@ibetitsmike ibetitsmike deleted the mike/fix-windows-deep-editor-links branch January 14, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant