-
Notifications
You must be signed in to change notification settings - Fork 42
🤖 feat: add Explorer Pane tab to RightSidebar #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0876a0a to
0453853
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0453853efb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Video: firefox_0xLTiziynd.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b4e2fe611
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
07539e1 to
6265159
Compare
Add a VS Code-style file explorer tree view as a new tab in the RightSidebar. Features: - Lazy-load directories on expand (efficient for large repos) - Tree view with expand/collapse, indented children - Toolbar with workspace path, Refresh, and Expand/Collapse All buttons - Auto-refresh after file-modifying tools (bash, file_edit_*) with 2s debounce - File icons via existing FileIcon component (Seti icon theme) - Folder icons with open/closed states - Path shortening (~ for home dir) with full path tooltip Backend: - Add listWorkspaceDirectory oRPC endpoint that returns both files and directories (unlike listDirectory which only returns directories) - Sorted: directories first, then files, both alphabetically - Filters out .git folder --- _Generated with `mux` • Model: `mux-gateway:anthropic/claude-opus-4-5` • Thinking: `high` • Cost: `$11.91`_
- Add 'ignore' npm package for gitignore pattern matching - Load .gitignore from workspace root and mark ignored files/directories - Display ignored items with 50% opacity - Skip gitignored directories when using Expand All - Add 'ignored' field to FileTreeNode schema
Previously only collected directories from already-loaded entries. Now recursively fetches each directory level before expanding children, ensuring all nested directories are expanded.
- Remove Expand All button (causes UI freeze on large trees) - Keep only Collapse All, shown when directories are expanded - Revert backend recursive listing (not needed without Expand All)
Addresses Codex review comment - if api is null when fetchDirectory is called, we now return early before setting loading state. Previously the loading flag would be set but never cleared, leaving the tree stuck on a spinner.
- Migrate persisted layouts to include explorer tab if missing - Use empty string for root directory key instead of __root__ (avoids collision with real folder named __root__)
- Set explicit 400px width for StatsTabIdle and StatsTabStreaming stories - Add listWorkspaceDirectory mock to orpc mock client - Add ExplorerTab story showing file tree with folders and files
- ExplorerTabExpanded: shows expanded src folder with Collapse All button - ExplorerTabSelected: shows package.json with focus/selected blue background - Update mock to return subdirectory contents for src/
6265159 to
4024847
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 402484745f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86d977d07e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
295d5a1 to
aaef246
Compare
aaef246 to
5589765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 295d5a1c4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64263bc7a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
For now we're just going to not support remotes. Will fix in post |
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9412306f0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Nested gitignores will be unhandled for now since they're complex. Will add in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ec0b3e3b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
7aab0bd to
9c1f22a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7aab0bd334
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
Add a VS Code-style file explorer tree view as a new tab in the RightSidebar.
Features
Backend
listWorkspaceDirectoryoRPC endpoint that returns both files and directories (unlikelistDirectorywhich only returns directories).gitfolderScreenshots
see comment
Generated with
mux• Model:mux-gateway:anthropic/claude-opus-4-5• Thinking:high• Cost:$11.91