Skip to content

Conversation

moo-im-a-cow
Copy link
Contributor

Added an optional envvar to vault-token module to handle communicating with a non default vault namespace.

in vault enterprise, you can run multiple secure isolated vault environments from the one vault server.
each namespace has it's own authentication methods and secrets engines.
vault uses the VAULT_NAMESPACE envvar to determine the namespace to use.
no value, or either root or / will use the root (default) namespace, any other value will use a different namespace

in vault community edition, the only supported namespace is "root", no other namespaces can be used.

in HCP vault dedicated (the saas hosted version), you cant access vault without a namespace set

this defaults to not setting the env var, so is backwards compatible, and works with vault CE

@moo-im-a-cow
Copy link
Contributor Author

the ci check appears to be failing on a different module not modified in this commit, filebrowser,

but i dont see vault-token mentioned in the log so i think the checks stopped at the errors and havent run against the vault-token module yet

@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label May 18, 2025
@DevelopmentCats
Copy link
Contributor

Looks good to me, but can you make sure to update the version in the README to reflect the minor version update to v1.1.1?

@DevelopmentCats DevelopmentCats merged commit a8d92df into coder:main May 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor Add to PRs requiring a minor version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants