Skip to content

Conversation

bcpeinhardt
Copy link
Collaborator

This PR copies the templates in coder/coder/examples/templates over to the registry, so that template contribution can be done through the registry.
For now, the starter templates in the coder/coder binary and the templates available in coder/registry will simply be different constructs, until we find a solution we like around a single source of truth for templates that doesn't raise hairy semver concerns for coder/coder: https://codercom.slack.com/archives/C05T7165ET1/p1749493368773469

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under Devcontainer, see "filesytem" is now "filesystem"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we replace all icons with SVGs, where possible?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly it's a product question whether y'all want to require contributors to use an svg here (I realize this is a coder template logo but in general).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we generally opt for SVG icons where available for all new icons on coder/coder too.

Copy link
Contributor

@DevelopmentCats DevelopmentCats Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like having this be a requirement wouldn't be too bad. I have had to convert a couple of PNG's to SVG and it wasn't too bad.

I can also look around and see if there are any reliable conversion tools, we could probably add a script to the workflow to auto convert PNG files to SVG that way we can account for PNG's still and handle all the existing PNG's

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should find the original SVGs instead of converting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this to something like box.png would help avoid any future confusion.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, this was the name it had in coder/coder so I just stuck with it.

@bcpeinhardt bcpeinhardt merged commit 0512430 into main Jun 12, 2025
4 checks passed
@bcpeinhardt bcpeinhardt deleted the bcpeinhardt/copy-templates branch June 12, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants