-
Notifications
You must be signed in to change notification settings - Fork 73
fix: consolidate template README images into single directory #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Parkreiner can we also add linting to enforce this for all future templates/modules. |
@matifali I agree that we need it The main problem is that the templates were brought into the repo without updating any of the validation logic to be aware that templates exist at all. I'd rather make a separate PR that addresses the template validation all in one go |
A separate PR is fine. Please create an issue for tracking. Thank you. |
|
||
<!-- Briefly describe what this PR does and why --> | ||
|
||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got rid of all these extra dividers because GitHub already automatically adds dividers for h2 headers
Description
This PR moves all the existing template README images for the Coder namespace from being defined inline to its
.images
directory. This makes the image-processing logic in the Registry build step easier to maintain.Type of Change
Testing & Validation
bun test
)bun run fmt
)Related Issues
Related to #132