Skip to content

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Jul 7, 2025

Description

This PR moves all the existing template README images for the Coder namespace from being defined inline to its .images directory. This makes the image-processing logic in the Registry build step easier to maintain.

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

Related to #132

@Parkreiner Parkreiner self-assigned this Jul 7, 2025
@matifali
Copy link
Member

matifali commented Jul 7, 2025

@Parkreiner can we also add linting to enforce this for all future templates/modules.

@Parkreiner
Copy link
Member Author

Parkreiner commented Jul 7, 2025

@matifali I agree that we need it

The main problem is that the templates were brought into the repo without updating any of the validation logic to be aware that templates exist at all. I'd rather make a separate PR that addresses the template validation all in one go

@matifali
Copy link
Member

matifali commented Jul 7, 2025

@matifali I agree that we need it

The main problem is that the templates were brought in without updating any of the validation logic to be aware of templates at all. I'd rather make a separate PR that addresses the template validation all in one go

A separate PR is fine. Please create an issue for tracking. Thank you.

@Parkreiner
Copy link
Member Author

@matifali Done #194


<!-- Briefly describe what this PR does and why -->

---
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got rid of all these extra dividers because GitHub already automatically adds dividers for h2 headers

@Parkreiner Parkreiner merged commit cde8fe3 into main Jul 7, 2025
4 checks passed
@Parkreiner Parkreiner deleted the mes/template-images branch July 7, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants