fix: improve VSCode-web settings merge with existing configurations #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=80&v=4){kind=small}
Enhance the settings handling in the VSCode-web module to properly merge user-defined settings with any existing settings file using jq when available. This ensures that settings from both the Terraform module and Coder's git authentication system are preserved. Related to coder/coder#19007 Co-authored-by: matifali <[email protected]>
|
Add some tests specifically for the settings Coder writes, as described in the issue coder/coder#19007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the VSCode-web module to better handle settings merging when existing configurations are present.
Changes
run.shto merge user-defined settings with existing settings filesTesting
Related to coder/coder#19007