Skip to content

Conversation

BenraouaneSoufiane
Copy link
Contributor

@BenraouaneSoufiane BenraouaneSoufiane commented Jul 24, 2025

Closes #79

Description

This PR add new module, install rustdesk package from deb file & execute the rustdesk cli then log the ID & password to be used within rustdesk client to connect to the host

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Overview/test video: https://youtu.be/J273d2ry99Q

Path: registry/coder/modules/rustdesk
New version: v1.0.0
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

/claim #79

@BenraouaneSoufiane
Copy link
Contributor Author

BenraouaneSoufiane commented Jul 24, 2025

@matifali can you release funds as the issue resolved & does not depends on me?
/claim #79

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The video does not show the RustDesk launching at the end. Can you show that too, and please address PR comments. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not include any assets. This should be downloaded as part of the installation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This folder is unrelated to rustdesk module

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file? Please delete.

Comment on lines +71 to +78
data "coder_parameter" "rustdesk" {
type = "string"
name = "rustdesk"
display_name = "Rustdesk"
icon = local.icon_url
mutable = var.mutable
default = "" # You may want to adjust this default value
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why a coder_parameter?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow the REDAME.md flow as seen in other modules.

@BenraouaneSoufiane
Copy link
Contributor Author

BenraouaneSoufiane commented Jul 24, 2025

The video does not show the RustDesk launching at the end. Can you show that too, and please address PR comments. Thanks.

It's not possible to launch rusdesk as containers does not have GUI (headless), I already mentioned it within the video, in case it possible it requires extra work (extra $$), & I'm not going to work on it anymore because it takes me much time, very very complicated not what I was expect, I'm going to fix mentioned issues, then someone continue resolving this issue, it requires launching some gui (gnome for example) within the container, attaching/export screen & other hardware, massive config, then launching rustdesk, which reach or exceed $1k, I'm looking to hear from you if you can release the funds or partial amount

@matifali
Copy link
Member

@BenraouaneSoufiane Thanks for your research here, What we are expecting in this module is to expose the HTML Client as a coder_app.

I am not aware of the GUI requirment. But if there is you can use the codercom/example-desktop image for testing.

@BenraouaneSoufiane
Copy link
Contributor Author

@BenraouaneSoufiane Thanks for your research here, What we are expecting in this module is to expose the HTML Client as a coder_app.

I am not aware of the GUI requirment. But if there is you can use the codercom/example-desktop image for testing.

Thank you for the guidance, in fact rustdesk is poor & limited does not have an html client, it's a full package not an html wrapper as you think, also the example desktop may be usefull, & propably I can launch it within that

@matifali matifali requested a review from DevelopmentCats July 24, 2025 19:28
@DevelopmentCats
Copy link
Contributor

I will keep an eye on this, and review once the updates have been pushed from the requested changes, and once this has been tested completely

@DevelopmentCats
Copy link
Contributor

DevelopmentCats commented Jul 24, 2025

Also just to add my 2 cents on rustdesk. This module would essentially be used for installing the rustdesk client inside of a workspace for a user so that they could connect to this desktop environment from rustdesk.

I dont think there would really be a useful coder app to expose here for the client since it essentially would work like an agent for most RMM's

Correct me if i'm wrong but I think all we are looking for is a module that will allow the users to configure it to install the client for the users rustdesk server instance.

RustDesk's docs appear to be down so I cannot confirm. (They might have the html client only available to enterprise users)

@BenraouaneSoufiane
Copy link
Contributor Author

Also just to add my 2 cents on rustdesk. This module would essentially be used for installing the rustdesk client inside of a workspace for a user so that they could connect to this desktop environment from rustdesk.

I dont think there would really be a useful coder app to expose here for the client since it essentially would work like an agent for most RMM's

Correct me if i'm wrong but I think all we are looking for is a module that will allow the users to configure it to install the client for the users rustdesk server instance.

RustDesk's docs appear to be down so I cannot confirm. (They might have the html client only available to enterprise users)

You are correct but the issue does not depends on me, because someone already requested to build a coder model, so after almost finish it I released that it's not suitable/possible for RMMs because they are runs headless without GUI, @matifali if possible issue a partial amount let say the half, but I still not tested it with desktop example it may runs without problems, but I think it's requires a massive configuration (extra work exceed 200$)

@matifali matifali closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustdesk module

3 participants