-
Notifications
You must be signed in to change notification settings - Fork 73
Add Rustdesk module #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rustdesk module #252
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The video does not show the RustDesk launching at the end. Can you show that too, and please address PR comments. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not include any assets. This should be downloaded as part of the installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder is unrelated to rustdesk module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file? Please delete.
data "coder_parameter" "rustdesk" { | ||
type = "string" | ||
name = "rustdesk" | ||
display_name = "Rustdesk" | ||
icon = local.icon_url | ||
mutable = var.mutable | ||
default = "" # You may want to adjust this default value | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why a coder_parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please follow the REDAME.md flow as seen in other modules.
It's not possible to launch rusdesk as containers does not have GUI (headless), I already mentioned it within the video, in case it possible it requires extra work (extra $$), & I'm not going to work on it anymore because it takes me much time, very very complicated not what I was expect, I'm going to fix mentioned issues, then someone continue resolving this issue, it requires launching some gui (gnome for example) within the container, attaching/export screen & other hardware, massive config, then launching rustdesk, which reach or exceed $1k, I'm looking to hear from you if you can release the funds or partial amount |
@BenraouaneSoufiane Thanks for your research here, What we are expecting in this module is to expose the HTML Client as a I am not aware of the GUI requirment. But if there is you can use the codercom/example-desktop image for testing. |
Thank you for the guidance, in fact rustdesk is poor & limited does not have an html client, it's a full package not an html wrapper as you think, also the example desktop may be usefull, & propably I can launch it within that |
I will keep an eye on this, and review once the updates have been pushed from the requested changes, and once this has been tested completely |
Also just to add my 2 cents on rustdesk. This module would essentially be used for installing the rustdesk client inside of a workspace for a user so that they could connect to this desktop environment from rustdesk. I dont think there would really be a useful coder app to expose here for the client since it essentially would work like an agent for most RMM's Correct me if i'm wrong but I think all we are looking for is a module that will allow the users to configure it to install the client for the users rustdesk server instance. RustDesk's docs appear to be down so I cannot confirm. (They might have the html client only available to enterprise users) |
You are correct but the issue does not depends on me, because someone already requested to build a coder model, so after almost finish it I released that it's not suitable/possible for RMMs because they are runs headless without GUI, @matifali if possible issue a partial amount let say the half, but I still not tested it with desktop example it may runs without problems, but I think it's requires a massive configuration (extra work exceed 200$) |
Closes #79
Description
This PR add new module, install rustdesk package from deb file & execute the rustdesk cli then log the ID & password to be used within rustdesk client to connect to the host
Type of Change
Module Information
Overview/test video: https://youtu.be/J273d2ry99Q
Path:
registry/coder/modules/rustdesk
New version:
v1.0.0
Breaking change: [ ] Yes [x] No
Testing & Validation
bun test
)bun run fmt
)Related Issues
/claim #79