Add Rustdesk module #266
Add Rustdesk module #266
Conversation
|
@matifali can you release the pending asset (150$)? |
This is released automatically once the PR is merged and closed |
No comment! But why I'm being delayed as this PR resolve the issue? |
There is no intentional delay, as Algora releases the bounty once the PR is approved, and merged. This is outlined in the Coder Bounty Issue #213 |
|
@BenraouaneSoufiane Just checking if there is any update on this? |
Fixed, thank you! |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new RustDesk module that enables remote desktop access within Coder workspaces. The module automates the installation of RustDesk, sets up a virtual display using Xvfb, and provides connection credentials for remote access.
Key changes:
- Adds a complete RustDesk module with cross-platform package manager support
- Implements automatic password generation and virtual display configuration
- Provides Terraform integration with configurable parameters
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
registry/BenraouaneSoufiane/modules/rustdesk/run.sh |
Main installation and setup script with package manager detection and RustDesk configuration |
registry/BenraouaneSoufiane/modules/rustdesk/main.tf |
Terraform module definition with variables and Coder resource configuration |
registry/BenraouaneSoufiane/modules/rustdesk/README.md |
Module documentation with usage instructions and configuration examples |
registry/BenraouaneSoufiane/README.md |
Author profile information |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@DevelopmentCats Hello again, thank you for you latest commits, I've checked the new version it works fine, https://youtu.be/YAMjDqFsV4I |
|
I think we are good to go on this one too. Since it has been a minute let me test this one last time, and then we should be able to get this merged tonight. @BenraouaneSoufiane |
Ok, thank you. |
|
@BenraouaneSoufiane can you run |
|
Hello @DevelopmentCats, any updates? |
|
Hello again @DevelopmentCats, how are you? I see all checks were passed. |
|
Okay everything looks good. @BenraouaneSoufiane The last thing I need from you before this is merged, is to upload the icon here: https://github.com/coder/coder/tree/main/site/static/icon You can make a PR and then comment to sign the authorization for the logo use, and then we should be good. |
|
Hello again @DevelopmentCats, submitted thank you: coder/coder#19841 |
As per @DevelopmentCats request here in my PR: coder/registry#266
|
Hello again @DevelopmentCats can you approve the workflow? |
|
Hello again @DevelopmentCats can you approve changes? |
|
@DevelopmentCats there is a ci fail (does not related with/depends on the my source) |
Yeah im not too sure what was going on there with the runner but it seems to have passed now. |
|
🎉🎈 @BenraouaneSoufiane has been awarded $150 by Coder! 🎈🎊 |
2 participants
Closes #79
Description
This PR add new module, install minimal desktop environment (xfce), virtual display, ,rustdesk package from deb file, init new screen, export DISPLAY environment variable with last created virtual screen, start new xfce session & execute the rustdesk cli, generate new password, change the default password, then log the ID & password to be used within rustdesk client to connect to the host
Type of Change
Module Information
Overview/test video: live demo that launch rustdesk with GUI in a docker container https://youtu.be/_rR-l7nARN4
Screenshots:
Path:
registry/BenraouaneSoufiane/modules/rustdeskNew version:
v1.0.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun run fmt)Related Issues
/claim #79 (remain asset 150$)