Skip to content

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Aug 16, 2025

Feature

Enables the claude-code module to work with binary Claude Code distribution without requiring Node.js to be installed on the system.

Changes

  • Removed the unconditional Node.js dependency check
  • Module now supports both installation methods:
    • install_claude_code=true: Installs via npm (requires Node.js)
    • install_claude_code=false: Uses binary distribution (no Node.js required)
  • Bumped module version to v2.1.0 (minor version bump)

Benefits

  • ✅ Users with binary Claude Code can use the module without Node.js
  • ✅ Maintains backward compatibility for npm installation
  • ✅ Reduces system requirements for binary distribution users
  • ✅ Follows the principle of minimal dependencies

Testing

Tested both scenarios:

  • install_claude_code=true: Works with npm installation
  • install_claude_code=false: Works without Node.js requirement

Addresses feedback from @aaronlehmann and @kylecarbs.

…ution

The claude-code module was checking for Node.js installation even when
install_claude_code=false (binary distribution). This check should only
run when installing via npm.

Fixes the issue where users with binary Claude Code distribution
couldn't use the module without Node.js installed.

Co-authored-by: kyle <[email protected]>
As requested by @kylecarbs, removing the Node.js check completely.
The module will work with binary Claude Code distribution without
requiring Node.js to be installed.

Co-authored-by: kyle <[email protected]>
@matifali
Copy link
Member

@35C4n0r can you complete this? We want to remove the node dependency entirely and use the direct binary installation.

@35C4n0r
Copy link
Collaborator

35C4n0r commented Aug 16, 2025

@matifali, PR ready for review.

PS: also want to mention, native install is still in beta.

matifali
matifali previously approved these changes Aug 17, 2025
@matifali matifali added the version:minor Add to PRs requiring a minor version upgrade label Aug 18, 2025
Copy link

❌ Version Bump Validation Failed

Bump Type: minor

Module versions need to be updated but haven't been bumped yet.

Required Actions:

  1. Run the version bump script locally: ./.github/scripts/version-bump.sh minor
  2. Commit the changes: git add . && git commit -m "chore: bump module versions (minor)"
  3. Push the changes: git push

Script Output:

🔍 Detecting modified modules...
Found modules:
registry/coder/modules/claude-code

📦 Processing: coder/claude-code
Found git tag: release/coder/claude-code/v2.0.7 (v2.0.7)
Current version: 2.0.7
New version: 2.1.0
Updating version references for coder/claude-code in registry/coder/modules/claude-code/README.md

🔧 Running formatter to ensure consistent formatting...

📋 Summary:
Bump Type: minor

Modules Updated:

- coder/claude-code: v2.0.7 → v2.1.0

READMEs Updated:

- coder/claude-code

✅ Version bump completed successfully!
📝 README files have been updated with new versions.

Next steps:
1. Review the changes: git diff
2. Commit the changes: git add . && git commit -m 'chore: bump module versions (minor)'
3. Push the changes: git push

Please update the module versions and push the changes to continue.

@matifali
Copy link
Member

Lets bump the minor version and update the title to pose this as a feature.
Something like using the install script to install.

@blink-so blink-so bot changed the title fix(claude-code): remove unnecessary Node.js check for binary distribution feat(claude-code): support binary distribution without Node.js dependency Aug 18, 2025
@matifali matifali merged commit 4dcaea7 into main Aug 18, 2025
4 checks passed
@matifali matifali deleted the fix/claude-code-remove-unnecessary-nodejs-check branch August 18, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor Add to PRs requiring a minor version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants