-
Notifications
You must be signed in to change notification settings - Fork 73
feat(claude-code): support binary distribution without Node.js dependency #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(claude-code): support binary distribution without Node.js dependency #332
Conversation
…ution The claude-code module was checking for Node.js installation even when install_claude_code=false (binary distribution). This check should only run when installing via npm. Fixes the issue where users with binary Claude Code distribution couldn't use the module without Node.js installed. Co-authored-by: kyle <[email protected]>
As requested by @kylecarbs, removing the Node.js check completely. The module will work with binary Claude Code distribution without requiring Node.js to be installed. Co-authored-by: kyle <[email protected]>
@35C4n0r can you complete this? We want to remove the node dependency entirely and use the direct binary installation. |
@matifali, PR ready for review. PS: also want to mention, native install is still in beta. |
❌ Version Bump Validation FailedBump Type: Module versions need to be updated but haven't been bumped yet. Required Actions:
Script Output:
|
Lets bump the minor version and update the title to pose this as a feature. |
Feature
Enables the
claude-code
module to work with binary Claude Code distribution without requiring Node.js to be installed on the system.Changes
install_claude_code=true
: Installs via npm (requires Node.js)install_claude_code=false
: Uses binary distribution (no Node.js required)Benefits
Testing
Tested both scenarios:
install_claude_code=true
: Works with npm installationinstall_claude_code=false
: Works without Node.js requirementAddresses feedback from @aaronlehmann and @kylecarbs.