fix(tag_release): improve macOS and Linux compatibility #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=80&v=4){kind=small}
…tinuations Fixes jq shell quoting issues on macOS where line continuations in jq commands cause syntax errors. The error 'unexpected module, expecting IDENT' was occurring because macOS shell/jq was not properly handling the backslash line continuations. Changes: - Remove line continuations from jq commands in add_json_error() - Remove line continuations from jq commands in add_json_warning() - Remove line continuations from jq commands in add_json_module() - Put all jq arguments and filter on single lines for better compatibility Tested on both Linux and the problematic commit c2bc5cd where the issue occurred.
…] instead of \s The \s regex pattern is not supported by macOS default sed, causing version extraction to fail and return entire lines instead of just version numbers. This resulted in validation errors like "Invalid version format" with full lines. Changes: - Replace \s* with [[:space:]]* in grep patterns - Replace \s* with [[:space:]]* in sed patterns - Ensures compatibility with both GNU sed (Linux) and BSD sed (macOS) Fixes both the original macOS version extraction issue and the Linux jq issue.
DevelopmentCats
approved these changes
Aug 18, 2025
|
Looks great to me! Sorry I work primarily on ubuntu machines with coder. I will make sure that the scripts I write are compatible with all Unix / MacOS devices going forward. I was trying to test this on my coder deployment but its giving me trouble this morning, so I will run it as soon as its up. I foresee no issues since they were just small changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two cross-platform compatibility issues in the
tag_release.shscript:Issues Fixed
1. macOS Version Extraction Issue
Problem: The script was showing errors like:
Root Cause: macOS's default BSD sed doesn't support
\sregex pattern for whitespace, causing version extraction to fail and return entire lines instead of just version numbers.Fix: Replace
\swith[[:space:]]in all regex patterns for cross-platform compatibility.2. Linux jq Syntax Issue
Problem: The script was showing errors like:
Root Cause: Line continuations in jq commands were causing shell parsing issues on some Linux environments.
Fix: Remove backslash line continuations from jq commands and put all arguments on single lines.
Changes Made
\s*with[[:space:]]*in grep and sed patternsadd_json_error(),add_json_warning(), andadd_json_module()Testing
✅ Tested on Linux with the current main branch
✅ Tested on the problematic commit
c2bc5cdwhere issues occurred✅ Verified version extraction works correctly with various whitespace patterns
✅ Confirmed jq commands execute without syntax errors
The script now correctly detects new modules from merge commits and can release them on both macOS and Linux systems.
@coder/chris-cat Please review when you have a chance!