Skip to content

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Aug 19, 2025

Closes #

Description

When grepping for httpd_directory the wrong file path was used.

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder/modules/kasmvnc
New version: v1.2.2
Breaking change: [ ] Yes [x] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@chgl chgl marked this pull request as ready for review August 19, 2025 14:41
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@matifali matifali enabled auto-merge (squash) August 20, 2025 07:29
@matifali matifali disabled auto-merge August 20, 2025 07:30
@matifali matifali added the version:patch Add to PRs requiring a patch version upgrade label Aug 20, 2025
@matifali matifali requested a review from Copilot August 20, 2025 07:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the KasmVNC module where the wrong configuration file path was being used to retrieve the httpd_directory setting. The fix ensures that the home directory configuration file is properly checked for user-specific overrides.

  • Corrected the file path from /etc/kasmvnc/kasmvnc.yaml to $HOME/.vnc/kasmvnc.yaml when checking for home directory overrides
  • Updated module version from v1.2.1 to v1.2.2

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
registry/coder/modules/kasmvnc/run.sh Fixed grep command to use correct home directory config file path
registry/coder/modules/kasmvnc/README.md Updated module version to v1.2.2

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@matifali matifali merged commit 29e5307 into coder:main Aug 20, 2025
5 checks passed
@chgl chgl deleted the patch-1 branch August 20, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch Add to PRs requiring a patch version upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants