Skip to content

Add healthcheck to JupyterLab module #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add healthcheck to JupyterLab module #346

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52af54
Add healthcheck to JupyterLab module
blink-so[bot] Aug 20, 2025
7979582
Address review feedback
blink-so[bot] Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion registry/coder/modules/jupyterlab/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,13 @@ resource "coder_app" "jupyterlab" {
share = var.share
order = var.order
group = var.group
}

# Healthcheck ensures JupyterLab is fully ready before showing as available
# Test with: git clone https://github.com/coder/registry.git && cd registry/registry/coder/modules/jupyterlab
# Then use this module in a template to verify the app only appears when JupyterLab is responding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comment.

healthcheck {
url = "http://localhost:${var.port}/api/status"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should handle both subdomain true and false case.

interval = 5
threshold = 6
}
}