Skip to content

Conversation

DevelopmentCats
Copy link
Contributor

Closes #

Description

add validation for module and namespace names to ensure they contain only alphanumeric characters and hyphens

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

…ntain only alphanumeric characters and hyphens
@Copilot Copilot AI review requested due to automatic review settings August 21, 2025 20:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds validation for module, template, and namespace names to ensure they contain only alphanumeric characters and hyphens. This validation helps maintain consistent naming conventions across the codebase.

Key changes:

  • Added a regular expression pattern to validate naming conventions
  • Implemented validation checks in resource subdirectory and namespace validation functions
  • Added descriptive error messages for invalid character usage
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@Parkreiner Parkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked it over with Atif, and just because we haven't even announced this module, we're just going to "unpublish" the old version by changing the namespace

@Parkreiner Parkreiner merged commit 8677e7d into main Aug 22, 2025
4 checks passed
@Parkreiner Parkreiner deleted the cat/validation-modules branch August 22, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants