Skip to content

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Aug 26, 2025

Closes #

Description

  • remove default node installation
  • users can pass amp versions now
  • move env variables to terraform variable (system prompt and ai prompt)

Type of Change

  • New module
  • Bug fix
  • Feature/enhancement
  • Documentation
  • Other

Module Information

Path: registry/coder-labs/modules/sourcegraph-amp
New version: v2.0.0
Breaking change: [x] Yes [ ] No

Testing & Validation

  • Tests pass (bun test)
  • Code formatted (bun run fmt)
  • Changes tested locally

Related Issues

@35C4n0r 35C4n0r self-assigned this Aug 26, 2025
@35C4n0r 35C4n0r requested a review from matifali September 7, 2025 05:52
Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments.

I'm going to pull and test this.

Copy link
Contributor

@DevelopmentCats DevelopmentCats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm cool with the shift in variable standards in Agent Modules, I just wanted to make sure this was intentional.

@DevelopmentCats
Copy link
Contributor

I'm testing this out, and everything seemed fine at first glance @35C4n0r

But I notice that the permissions are not permissive enough for the docker tasks template, and it ends up stopping to ask the user for permissions to use tools.

Ideally we want this to work for tasks out of the box, and then the configuration would be updated by the user if they desire different behavior. Much like how the claude-code module works for tasks without needing to update the whole base config.

It might also be useful to link the docs for amp permissions in the README

image

Comment on lines +26 to 32
function check_dependencies() {
if ! command_exists node; then
printf "Error: Node.js is not installed. Please install Node.js manually or use the pre_install_script to install it.\n"
exit 1
fi

if ! command_exists npm; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's switch to using the install script.

curl -fsSL https://ampcode.com/install.sh | bash

https://ampcode.com/manual#getting-started-command-line-interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants