-
Notifications
You must be signed in to change notification settings - Fork 73
feat: refactor claude code to use agentapi module #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # registry/coder/modules/claude-code/README.md # registry/coder/modules/claude-code/main.tf # registry/coder/modules/claude-code/scripts/agentapi-start.sh # registry/coder/modules/claude-code/scripts/agentapi-wait-for-start.sh # registry/coder/modules/claude-code/testdata/agentapi-mock.js
Linked the issue, the issue also asks for subdomain, will add that today. |
added subdomain 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Provided we are cool with the shift of standardization in variables for AI Modules this looks good to me. I have tested and it works fine.
@35C4n0r can you resolve the conflicts here? |
# Conflicts: # registry/coder/modules/claude-code/README.md # registry/coder/modules/claude-code/main.test.ts # registry/coder/modules/claude-code/main.tf # registry/coder/modules/claude-code/testdata/agentapi-mock.js
Co-authored-by: Atif Ali <[email protected]>
Co-authored-by: Atif Ali <[email protected]>
I updated the tasks template for this update. We should be good here to merge but Ill let you guys take a look at the PR for the the template and I can push these all at once |
We are good here but I cant do final approval since I was the one who made the last commit. |
@DevelopmentCats let's also add an explicit example to use the Claude Max subscription as suggested by @bpmct here: #358 (comment) |
@matifali @DevelopmentCats added the example |
@35C4n0r, let's merge and release this and then test the template and release that too. Thanks for your work on this. |
## Description Refactor template for claude-code module update for tasks ## Type of Change - [ ] New module - [ ] Bug fix - [ ] Feature/enhancement - [ ] Documentation - [X] Other ## Testing & Validation - [X] Tests pass (`bun test`) - [X] Code formatted (`bun run fmt`) - [X] Changes tested locally ## Related Issues #402 --------- Co-authored-by: Atif Ali <[email protected]>
Closes #302
Description
Type of Change
Module Information
Path:
registry/[namespace]/modules/[module-name]
New version:
v3.0.0
Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test
)bun run fmt
)Related Issues