Skip to content

Add trusted_domains variable to code-server module for link protection #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Foorack wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add trusted_domains variable to code-server module for link protection #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7eb6c7d
Add trusted_domains variable to code-server module for link protectio…
Copilot Sep 27, 2025
a6e4529
Update registry/coder/modules/code-server/run.sh
Foorack Oct 16, 2025
f270cf6
Merge branch 'main' into link-protection-trusted-domains
DevelopmentCats Nov 18, 2025
d26e474
Merge branch 'main' into link-protection-trusted-domains
DevelopmentCats Jan 9, 2026
37d20b0
Merge branch 'main' into link-protection-trusted-domains
Foorack Jan 13, 2026
4dac779
Make TRUSTED_DOMAINS parsing consistent with EXTENSIONS pattern (#2)
Copilot Jan 13, 2026
8ad636a
Merge branch 'main' into link-protection-trusted-domains
Foorack Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions registry/coder/modules/code-server/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,12 @@ variable "open_in" {
}
}

variable "trusted_domains" {
type = list(string)
description = "A list of trusted domains for link protection. These domains will be added to the --link-protection-trusted-domains option."
default = []
}
Comment on lines +151 to +155
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a test case to code-server.tftest.hcl that verifies the trusted_domains variable is properly handled. This could include a test with multiple domains to ensure the comma-separated list is processed correctly in the shell script.

Copilot uses AI. Check for mistakes.

variable "additional_args" {
type = string
description = "Additional command-line arguments to pass to code-server (e.g., '--disable-workspace-trust')."
Expand All @@ -174,6 +180,7 @@ resource "coder_script" "code-server" {
EXTENSIONS_DIR : var.extensions_dir,
FOLDER : var.folder,
AUTO_INSTALL_EXTENSIONS : var.auto_install_extensions,
TRUSTED_DOMAINS : join(",", var.trusted_domains),
ADDITIONAL_ARGS : var.additional_args,
})
run_on_start = true
Expand Down
14 changes: 13 additions & 1 deletion registry/coder/modules/code-server/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,22 @@ if [ -n "${EXTENSIONS_DIR}" ]; then
mkdir -p "${EXTENSIONS_DIR}"
fi

# Set trusted domains argument
TRUSTED_DOMAINS_ARG=""
if [ -n "${TRUSTED_DOMAINS}" ]; then
# Split comma-separated domains and create multiple --link-protection-trusted-domains arguments
IFS=',' read -r -a DOMAIN_ARRAY <<< "${TRUSTED_DOMAINS}"
for domain in "$${DOMAIN_ARRAY[@]}"; do
if [ -n "$domain" ]; then
TRUSTED_DOMAINS_ARG="$TRUSTED_DOMAINS_ARG --link-protection-trusted-domains=$domain"
fi
done
fi

function run_code_server() {
echo "👷 Running code-server in the background..."
echo "Check logs at ${LOG_PATH}!"
$CODE_SERVER "$EXTENSION_ARG" --auth none --port "${PORT}" --app-name "${APP_NAME}" ${ADDITIONAL_ARGS} > "${LOG_PATH}" 2>&1 &
$CODE_SERVER "$EXTENSION_ARG" $TRUSTED_DOMAINS_ARG --auth none --port "${PORT}" --app-name "${APP_NAME}" ${ADDITIONAL_ARGS} > "${LOG_PATH}" 2>&1 &
}

# Check if the settings file exists...
Expand Down