fix(codex): pass folder variable to agentapi module #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The folder variable was not being passed from the codex module to the agentapi module, causing agentapi to use its default value of /home/coder instead of the user-specified folder path. This resulted in permission errors when the codex module tried to create directories in /home/coder when users specified a different folder like /home/matt/foo. Fix by adding folder = var.folder to the agentapi module invocation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
DevelopmentCats
previously requested changes
Oct 14, 2025
There was a problem hiding this comment.
Great Catch!
@matthazinski Can you bump the version using the version bump script?
./.github/scripts/version-bump.sh patch
|
@DevelopmentCats', let's do that and approve and merge the PR. |
|
@matifali Done Can you approve? |
matifali
approved these changes
Oct 14, 2025
|
Thanks, @matthazinski, for the fix. |
|
Thanks for the for the fix! @matthazinski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The folder variable was not being passed from the codex module to the agentapi module, causing agentapi to use its default value of
/home/coderinstead of the user-specified folder path.This resulted in permission errors when the codex module tried to create directories in
/home/coderwhen users specified a different folder like/home/matt/foo.Fix by adding
folder = var.folderto the agentapi module invocation.Type of Change
Module Information
Path: registry/coder-labs/modules/codex
New version: v2.1.1
Breaking change: [ ] Yes [X] No
Testing & Validation
bun test)bun fmt)Related Issues
Fixes #476